feat: normalize master key ID to "master" for deterministic PRISM DID#1735
Draft
yshyn-iohk wants to merge 3 commits intomainfrom
Draft
feat: normalize master key ID to "master" for deterministic PRISM DID#1735yshyn-iohk wants to merge 3 commits intomainfrom
yshyn-iohk wants to merge 3 commits intomainfrom
Conversation
Change DEFAULT_MASTER_KEY_ID from "master0" to "master" per the deterministic DID creation spec. The cloud-agent already uses CompressedECKeyData for secp256k1, so only the key ID normalization is needed for cross-platform DID determinism. Closes #1732 Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Contributor
CreateDIDOperation now includes only the master key with CompressedECKeyData. All other keys, services, and contexts must be added via subsequent UpdateDIDOperation. Keys are still derived and stored during createAndStoreDID for use in subsequent UpdateDID operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Verify that raw spec seed produces: - Compressed pubkey: 023f7c75c9e5fba08fea1640d6faa3f8dc0151261d2b56026d46ddcbe1fc5a5bbb - Canonical DID: did:prism:35fbaf7f8a68e927feb89dc897f4edc24ca8d7510261829e4834d931e947e6ca Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
|
Contributor
Author
|
We need to clarify the behavior of the deterministic PRISM DID specification for the long-form DID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_MASTER_KEY_IDfrom"master0"to"master"per deterministic DID creation specCompressedECKeyDatafor secp256k1, so only key ID normalization was neededTest plan
"master"Closes #1732
🤖 Generated with Claude Code