fix(soroban): skip empty CFGs in emit_functions_with_spec#1914
Open
0xull wants to merge 1 commit into
Open
Conversation
fixes hyperledger-solang#1906 Signed-off-by: 0xull <mrikehchukwuka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
an unused modifier produces a CFG with no basic blocks. the Soroban
emit path passed it to
emit_cfgwhich calledcreate_blockand indexedinto the empty block list, panicking. the generic
emit_functionspathalready guards against this with
cfg.is_placeholder(). apply the sameguard in
emit_functions_with_spec.Fix
one guard added in
src/emit/soroban/mod.rsto skip any CFG wherecfg.is_placeholder()returns true before passing it toemit_cfg.Tests
one test in
tests/soroban_testcases/modifiers.rsthat compiles the exact MRE from the issue and invokesrun()to show the contract is not only panic-free but executable.Fixes #1906