Fix missing FAIL diagnostic reporting in codegen tests#1925
Open
modernzju wants to merge 1 commit into
Open
Conversation
Signed-off-by: modernzju <modernzju@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the codegen test harness to report the unmatched
// FAIL:directive usingcurrent_failinstead ofcurrent_check.The previous code indexed into
failswithcurrent_check, which can point at the wrong entry or panic with an unrelated index when aFAILexpectation is not found. This change reports the actual missingFAILexpectation and includes the testcase path, matching the existingCHECKfailure output style.Testing
cargo fmt --checkgit diff --check-
cargo test --test codegen