Return JsonNode directly in JSONDocument#318
Open
suddendust wants to merge 3 commits into
Open
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
puneet-traceable,
skjindal93 and
suresh-prakash
as code owners
July 16, 2026 09:12
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
============================================
- Coverage 80.90% 80.89% -0.01%
- Complexity 1579 1580 +1
============================================
Files 242 242
Lines 7626 7628 +2
Branches 751 751
============================================
+ Hits 6170 6171 +1
- Misses 967 968 +1
Partials 489 489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
suresh-prakash
previously approved these changes
Jul 16, 2026
Contributor
|
Good optimisation. |
puneet-traceable
previously approved these changes
Jul 16, 2026
suddendust
dismissed stale reviews from puneet-traceable and suresh-prakash
via
July 16, 2026 10:53
77d882a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a method
Document#getJsonNode()that returns theJsonNodecorresponding to a document. This method is useful to avoid double translation in client that currently read theJSONstring and convert it to aJsonNode. With this, they can avoid this deserialisation.Testing
Change is trivial, added a UT.
Checklist: