fix: propagate ABCI errors instead of swallowing them #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
Issue
When simulation fails,
abciQuerywasn't checking the ABCI response code. IffromBase64()happened to succeed on empty/garbage data, the error got swallowed entirely. Users end up seeinggasWanted: 0, gasUsed: 1000with no idea why.Fix
Check
response['code'] !== 0before trying to decode. If it's non-zero, throw anAbciErrorwith the code and log message so callers can actually see what went wrong.Added a new
AbciErrortype to@interchainjs/typesthat includes the raw ABCI code and log: