Skip to content

Fix runner terminal launch#82

Open
goyalpalak18 wants to merge 2 commits intohyphae:add-license-1from
goyalpalak18:fix-runner-terminal-launch
Open

Fix runner terminal launch#82
goyalpalak18 wants to merge 2 commits intohyphae:add-license-1from
goyalpalak18:fix-runner-terminal-launch

Conversation

@goyalpalak18
Copy link

Summary

This PR fixes a startup issue in runner.sh where APIS services would fail to launch on Linux systems using KDE Plasma (konsole) or XFCE (xfce4-terminal).

The Problem

The script was attempting to pass compound shell commands (e.g., cd ... && ...) directly to the terminal emulator's execution flag. Unlike GNOME Terminal, both konsole and xfce4-terminal expect a single executable path rather than a shell string. This caused the terminal windows to either close immediately or fail with a "command not found" error, preventing the emulator from starting.

The Solution

I updated the launch logic for both konsole and xfce4-terminal to wrap the commands in a bash -c subshell.

  • This ensures the directory change and command execution are interpreted correctly by the shell.
  • I also explicitly added a command to keep the shell session open after execution, ensuring the terminal window remains visible (honoring the intended "hold" behavior).

Verification

To verify this fix:

  1. Use a Linux environment running KDE Plasma or XFCE.
  2. Run make run-apis-emulator.
  3. Result: The terminal window now opens successfully and remains open while the emulator runs, instead of crashing on startup.

Palak Goyal and others added 2 commits January 30, 2026 10:30
Signed-off-by: Palak Goyal <palakgoyal@Palaks-MacBook-Pro.local>
Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
@goyalpalak18 goyalpalak18 force-pushed the fix-runner-terminal-launch branch from 0e765d0 to a9d2c6f Compare January 30, 2026 05:01
@AkarshSahlot
Copy link
Contributor

@Dipeua have a look o this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants