Open
Conversation
Signed-off-by: Palak Goyal <palakgoyal@Palaks-MacBook-Pro.local>
Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
0e765d0 to
a9d2c6f
Compare
Contributor
|
@Dipeua have a look o this |
axmsoftware
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a startup issue in
runner.shwhere APIS services would fail to launch on Linux systems using KDE Plasma (konsole) or XFCE (xfce4-terminal).The Problem
The script was attempting to pass compound shell commands (e.g.,
cd ... && ...) directly to the terminal emulator's execution flag. Unlike GNOME Terminal, bothkonsoleandxfce4-terminalexpect a single executable path rather than a shell string. This caused the terminal windows to either close immediately or fail with a "command not found" error, preventing the emulator from starting.The Solution
I updated the launch logic for both
konsoleandxfce4-terminalto wrap the commands in abash -csubshell.Verification
To verify this fix:
make run-apis-emulator.