auth/fingerprint: implement retry logic for device connection and verification#943
Closed
MrBurgerCZ wants to merge 1 commit into
Closed
auth/fingerprint: implement retry logic for device connection and verification#943MrBurgerCZ wants to merge 1 commit into
MrBurgerCZ wants to merge 1 commit into
Conversation
Collaborator
|
So #971 is a slightly better version of this, but please read there for why I think it isn't a good idea. |
Author
|
Totally understand that, I was expecting this kind of outcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that because of my fingerprint scanner drivers (open-fprintd + python-validity) it takes some time for it to initialize after resuming from suspend. and also that hyprlock just doesn't even wait. so I vibecoded (not exactly proud of that, but I don't know c++ yet, sorry) something hoping to fix it. it probably isn't good, but it works on my system.
i know that this should probably be fixed on the driver side, but I find this more useful and broader.
changes
try-catchblocks to prevent crashes when the service isn't ready immediately.auth:fingerprint:init_retriesandauth:fingerprint:init_retry_delayto control the patience level.