Closed
Conversation
hzhou
force-pushed
the
2103_typemap
branch
2 times, most recently
from
36ed4ec to
74e22a2
Compare
Even though a struct may have heterogenous basic datatypes, the builtin-elements count is still meaningful. For example, it is the number of entries in the typemap. This commit prepares for typemap utilitis. Typemap is useful for debugging datatype issues and simplify algorithms.
hzhou
force-pushed
the
2103_typemap
branch
2 times, most recently
from
743d3fb to
2c38a75
Compare
Handle MPI_2INT correctly for n_builtin_elements, builtin_element_size, and basic_type.
Adds type map and type signature routines. These routines are useful for debugging and datatype functions such as type matching and external32 packing/unpacking.
Add MPIX_Type_dump_typemap and MPIX_Type_dump_typesig. These functions allows datatype debugging and testing.
The typemap routines are very complex to maintain. The MyDef sources allow higher level code organizations.
This is a testing code. Requires https://github.com/hzhou/mpi-def.git
Owner
Author
|
Replace by #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Provide two internal utility functions:
struct typemap *MPIR_type_get_typemap(MPI_Datatype dt)struct typesig *MPIR_type_get_typesig(MPI_Datatype dt)with
These two function returns an internal data structure with allocated memory, so it is difficult to expose to the user. So we also provide two user functions that just prints to stdout (I know, not ideal):
MPIX_Type_dump_typemap(MPI_Datatype datatype)MPIX_Type_dump_typesig(MPI_Datatype datatype)Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.