Conversation
# Conflicts: # py2store/persisters/mongo_w_pymongo.py
|
There are persisters that I could not think of a proper way to add uri/collection args:
Also, while implementing it, there were persisters with 2 kinds of URI param - as a string like And I feel concerned about this. 2 types, not consistent. Maybe convert string-typed URIs to dict ones also. Would be more complex to use, but more consistent overall. |
thorwhalen
left a comment
There was a problem hiding this comment.
What we talked about during our chat...
| files_list_folder_kwargs=None, rev=None): | ||
| def __init__( | ||
| self, | ||
| rootdir, |
| data_fields=None, | ||
| ): | ||
| db_name = uri.pop('db_name') | ||
| self._mongo_client = MongoClient(**uri) |
There was a problem hiding this comment.
It seems like old interface is broken with this. Need to either change all usages of MongoPersister, or handle the case where uri is db_name. I'll look into this myself, but note this effect for other persisters you take care of.
Per #38