Skip to content

Fix migrations release lock issue #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2y merged 1 commit into from
Apr 5, 2026
+8 −9
Merged

Fix migrations release lock issue #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions edda/storage/migrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ async def migration_lock(engine: AsyncEngine, db_type: str) -> AsyncIterator[boo
yield True
return

acquired = False
try:
async with engine.connect() as conn:
async with engine.connect() as conn:
acquired = False
try:
if db_type == "postgresql":
# Try to acquire advisory lock (non-blocking)
result = await conn.execute(
Expand All @@ -202,18 +202,17 @@ async def migration_lock(engine: AsyncEngine, db_type: str) -> AsyncIterator[boo
logger.debug("Could not acquire migration lock, another worker is migrating")
yield False

finally:
if acquired:
try:
async with engine.connect() as conn:
finally:
if acquired:
try:
if db_type == "postgresql":
await conn.execute(text(f"SELECT pg_advisory_unlock({MIGRATION_LOCK_KEY})"))
await conn.commit()
elif db_type == "mysql":
await conn.execute(text("SELECT RELEASE_LOCK('edda_migration')"))
await conn.commit()
except Exception as e:
logger.warning(f"Failed to release migration lock: {e}")
except Exception as e:
logger.warning(f"Failed to release migration lock: {e}")


def extract_version_from_filename(filename: str) -> str:
Expand Down
Loading