Refactor ConformalTrackingV2 Configuration#165
Conversation
|
Some more structured form for configuring conformal tracking has been introduced in the Gaudi port: https://github.com/key4hep/k4Reco/blob/9a8b181c092e1eb04640869820328a04392a52d6/k4Reco/ConformalTracking/options/runConformalTracking.py#L98-L183 See also key4hep/k4Reco#23 for some more details / discussion. Maybe it's possible to write a similar utility function that converts the dict into the parameters for the wrapped version? |
|
Have a look at this PR: key4hep/CLDConfig#70 where the parameters for tracking for the CLD reconstruction are changed to a more structured format while there are some conversions (look for |
Exactly what I was thinking. I didn’t want to spend too much time on it initially, so I just went with the minimal bug fix. But I have now implemented the function or at least I do provide a suggestion :) |
Thank you for bringing this to my attention. It wasn't even on my radar :)
In
I would guess that pylint would have some suggestions for improvement there. Let me know what you think :) |
d1aabea to
43967b2
Compare
|
Thanks. This looks good to me. Could you change the PR title and the release notes to better reflect the changes that are now done with this PR? |
|
I suggest to not squash the two commits as they are orthogonal. First, the wrong position of the fmt on/off statements is fixed and later, the |
BEGINRELEASENOTES
ConformalTrackingV2processor configuration inTrackingReco_FCCeeMDI.pyThe previous manual string-list definition for the
Stepsparameter was unwieldy, especially with autoformatting that spread each item across a new line. This change introduces a new utility function,encode_CT_steps_dict_to_legacy_listinpy_utils.py, allowing the conformal tracking steps to be defined using a structured Python dictionary.This significantly improves readability and maintainability by:
This is a refactoring effort only; the physics behavior of
ConformalTrackingV2should remain unchanged.ENDRELEASENOTES