feat(cron): deduplicate and protect scheduled executions#601
Open
JAVA-LW wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(job_id, scheduled_at)claimCloses #600
Why
Conversation busy state alone cannot prevent duplicate callbacks from creating two independent conversations. The occurrence claim must happen at the task/database level before any conversation is materialized.
Implementation
queue_enabledto cron jobscron_job_runswith a unique occurrence key and active-run indexBEGIN IMMEDIATEfor atomic cross-process claimsscheduled_atthrough retries and scheduler callbacksTesting
RUSTUP_TOOLCHAIN=stable cargo fmt --all -- --checkRUSTUP_TOOLCHAIN=stable cargo check -p aionui-cron -p aionui-db -p aionui-appRUSTUP_TOOLCHAIN=stable cargo test -p aionui-cron -p aionui-db -p aionui-api-typesRUSTUP_TOOLCHAIN=stable cargo test -p aionui-app --test cron_e2eAll checks pass on the latest upstream
main.Related UI
The corresponding queue-protection UI and visual schedule builder are in iOfficeAI/AionUi#3552.