Skip to content

Feature/tags#140

Closed
shunchu wants to merge 27 commits intoiStefo:masterfrom
shunchu:feature/tags
Closed

Feature/tags#140
shunchu wants to merge 27 commits intoiStefo:masterfrom
shunchu:feature/tags

Conversation

@shunchu
Copy link
Copy Markdown

@shunchu shunchu commented May 4, 2016

Merged steffenbrem's tags feature.

cr: @scottt2

Kuba Niechciał and others added 27 commits February 26, 2015 16:52
I am currently working on supporting tags in this component, while also
supporting ember data. You can pass in an ember data record array
(DS.RecordArray) instance, and it will create new tags based on the
`type` of the recordarray.

This PR is still a WIP, any feedback is welcome!
Ability to format result

# Conflicts:
#	addon/components/select-2.js
Tagging support; format formatNoMatches; format formatSelection

# Conflicts:
#	addon/components/select-2.js
* formatSearch
* formatSelection
* sortable
ember objects instead of ember data models. This is automatically
determined by this component.
assimilate a working version of result formatting
…re/tags

# Conflicts:
#	addon/components/select-2.js
@shunchu shunchu closed this May 4, 2016
@shunchu shunchu deleted the feature/tags branch May 4, 2016 17:13
@shunchu shunchu restored the feature/tags branch May 4, 2016 17:14
@shunchu shunchu deleted the feature/tags branch May 4, 2016 17:16
@scottrblock
Copy link
Copy Markdown

Hi @shunchu, why was this closed/deleted? Happy to try to help if I can, though I'm still pretty new to ember. Looking into using this addon but need tagging support. Hoping @steffenbrem's PR is merged into master soon.

@shunchu
Copy link
Copy Markdown
Author

shunchu commented May 10, 2016

@scottrblock, it was meant to merge into my own master for a project I'm working o, but I made a wrong PR. It's simply a slightly fixed up version of #92 with 2 differences:

@scottrblock
Copy link
Copy Markdown

@shunchu great, thanks! Has your fork been working well for tagging so far?

@shunchu
Copy link
Copy Markdown
Author

shunchu commented May 10, 2016

Yup. We just built a feature using it. It works great.

Here's how we're using it now:

  • From our server, we eager-load all the tags we'd like to make available to our users
  • When user enters strings that don't match one of the pre-loaded tags, ember-select-2 will accept the strings as-is. And when user submits the form, we simply pass the entire tags payload to the server, and the server figures out which tags already exist and which ones need to be created and associated (we have a Rails app using this gem to deal with tagging: https://github.com/mbleigh/acts-as-taggable-on).

@shunchu
Copy link
Copy Markdown
Author

shunchu commented May 11, 2016

Also, @steffenbrem, the original author who added the tagging support, added an example in the dummy app of the add-on. It's pretty self-explanatory once you looked at the dummy app's example.

@scottrblock
Copy link
Copy Markdown

Thanks @steffenbrem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants