Refactor repo into coherent feature slices#15
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0f943f5fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,18 @@ | |||
| import { ANSI, isTTY, parseKey, shouldUseColor } from "./ansi.js" | |||
| export const ANSI = { | |||
There was a problem hiding this comment.
Add ratchet baselines for newly introduced source files
This refactor introduces new TypeScript paths (for example lib/ui/tty.ts) without corresponding entries in scripts/coverage-ratchet.baseline.json, but scripts/check-coverage-ratchet.mjs fails changed files that have coverage and no baseline entry. With this commit range, the ratchet already reports lib/ui/tty.ts: missing coverage baseline entry, so npm run verify will fail once coverage is generated; please add baseline records for all newly added/renamed .ts files in this diff.
Useful? React with 👍 / 👎.
|
|
||
| if (isDistMode) { | ||
| const distRoot = path.resolve("dist") | ||
| if (!fs.existsSync(distRoot)) { |
There was a problem hiding this comment.
Validate dist root is a directory in --dist mode
The --dist guard now checks only existsSync(dist) and does not verify that dist is a directory, so a plain file named dist makes the script exit successfully without scanning any built JS files. This regresses the old fail-fast behavior and can produce false-positive passes for check:dist-esm-imports when build output is missing or malformed.
Useful? React with 👍 / 👎.
Summary
Testing
node scripts/check-esm-import-specifiers.mjs --distfrom a temp dir now fails fast whendist/is missinggit diff --checknpm run verifypreviously passed for this refactor before moving into this worktreevitest/tscbinaries, so I could not rerun the automated suites hereAudit
dist/fail-fast guard and dropped config barrel exports