Skip to content

🔍 Lens: Fix typographic scale inversion in Settings & ContentView#19

Open
iamkeeler wants to merge 1 commit into
mainfrom
jules-6456523338276352721-428c88ea
Open

🔍 Lens: Fix typographic scale inversion in Settings & ContentView#19
iamkeeler wants to merge 1 commit into
mainfrom
jules-6456523338276352721-428c88ea

Conversation

@iamkeeler

Copy link
Copy Markdown
Owner

The Problem:
In FormattingCustomizationView, the page's main title "Rich Text Formatting" used .title3, but the specific element header (e.g. "Body Text") used .title2. This inverted the typographical hierarchy, creating cognitive friction by making the sub-section visually more dominant than the page title. In ContentView, the "Markdown" label used .subheadline, which was too small to establish a clear section hierarchy over the input field.

The Visual Logic:
Typographic Scale dictates that headings must be larger than body text and descend logically (Page > Section > Component). By promoting the Page Title to .title2 and demoting the section header to .title3, we map the visual hierarchy to the logical hierarchy. Promoting the input label to .headline establishes it as a section leader without overpowering the CTA.

The Surgery:
Modified existing .font() view modifiers in FormattingCustomizationView.swift and ContentView.swift. No new components or custom font sizes were created; relied entirely on Apple's standard dynamic type scale values (.headline, .title2, .title3).

A11y/IA Impact:
Standardizing to the correct Apple dynamic type scale improves the predictability of the mental model, ensuring users immediately recognize their current context within the hierarchy, while fully supporting dynamic type scaling.


PR created automatically by Jules for task 6456523338276352721 started by @iamkeeler

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant