Fixed enable the mutation of a unmarshaled json.#39
Open
mabels wants to merge 1 commit intoiancoleman:masterfrom
Open
Fixed enable the mutation of a unmarshaled json.#39mabels wants to merge 1 commit intoiancoleman:masterfrom
mabels wants to merge 1 commit intoiancoleman:masterfrom
Conversation
In the decode methods the nested orderedMaps had
not been pointer with prevents the mutation.
To the fix broke some tests the cast to x.(OrderedMap)
failed. To Fix this the OrderedMap is now an interface.
This broke the TestUnmarshalJSONStruct test to fix
the export of OrderedMapImpl is need. This change
is a breaking!
|
Can confirm, this PR fixes the issues I had with nested JSON. If you can merge it, that'd be super helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for awesome work --- and sorry for breaking things
meno