Show text along with spinner, implementation of cli-spinners, and code update#6
Open
sgb004 wants to merge 9 commits into
Open
Show text along with spinner, implementation of cli-spinners, and code update#6sgb004 wants to merge 9 commits into
sgb004 wants to merge 9 commits into
Conversation
var was change for let or const. Using modern (current) javascript, for example, var was changed to let or const. The function change_sequence was change to use camelCase Changes to add a text with the spinner.
Changes to use the spinners of cli-spinners. Deletion of the function change_sequence, now to change the sequence it can be done through the start function. The time interval changed from being a parameter of the start function to being one of the options of the start function. Changes in the test.js file to apply the changes in the spinner.js file.
… set an interval, as the interval will be obtained from the information of the spinner in the cli-spinners json.
Added contributors and changed the version from 0.0.5 to 0.0.6
Added contributors and changed the version from 0.0.5 to 0.0.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first, I only wanted to add the ability to display text alongside the spinner, but ended up updating the code by making simple changes such as replacing 'var' with 'const' or 'let'. Later, I thought it would be beneficial for the plugin to have the option of choosing a spinner from the cli-spinners library (https://github.com/sindresorhus/cli-spinners), so I made some changes to enable the selection of a spinner from that library.
Other changes I made included removing the 'change_sequence' function and moving the sequence change to the 'start' function, as I thought it would be simpler that way. Additionally, I moved the interval within the options of the 'start' function.