fix(gir): consider implied null-terminated for array types#148
Draft
ianprime0509 wants to merge 1 commit into
Draft
fix(gir): consider implied null-terminated for array types#148ianprime0509 wants to merge 1 commit into
ianprime0509 wants to merge 1 commit into
Conversation
ianprime0509
force-pushed
the
push-owqrwmxqntox
branch
3 times, most recently
from
November 28, 2025 02:05
720c41a to
c2ee453
Compare
ianprime0509
force-pushed
the
push-owqrwmxqntox
branch
from
November 28, 2025 02:32
c2ee453 to
5e17351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
TODO: see if the other remaining GIR fixes from #107 are still needed.
TODO: the heuristic for scalar array element types is ugly and probably should be improved
TODO: the test case for an array of
gpointers which itself has C typegpointeris very tricky and needs additional handlingThere are cases to consider related to using
gpointeras the C type for arrays:xmlstarlet sel -t -m "//_:array[@c:type='gpointer']" -c ../../.. /usr/share/gir-1.0/*.girxmlstarlet sel -t -m "//_:array[@c:type='gconstpointer']" -c ../../.. /usr/share/gir-1.0/*.gir