feat: add support for Zig 0.16#61
Conversation
| const output = output: { | ||
| const index = reader.attributeIndex("OUTPUT") orelse break :output null; | ||
| defer gpa.free(input.parent); | ||
| const output: struct { parent: ?[]u8, data: ?[]u8 } = output: { |
There was a problem hiding this comment.
this feels v janky but was having an invalid free because (I think?) the readFile returned a view into the greater buf slice and then when we freed that we freed only the view not the full slice. im sure theres a better way but this works/tests ran/no allocator complaints
There was a problem hiding this comment.
It looks like there's a TODO to move readFileAlloc to std.Io.Dir: https://github.com/ziglang/zig/blob/bdbfc7de3fd3a05f338ec8beaa29894547a9df4c/lib/std/fs/Dir.zig#L1425-L1426 So, hopefully, this workaround will be unnecessary in the long run. (If it doesn't get moved for some reason, I would probably end up just copying the core logic of readFileAlloc)
There was a problem hiding this comment.
copy that, will keep an eye and update if/when stuff changes or do as you suggested!
|
Thank you! I actually made the changes for I'll be happy to merge this once 0.16 comes out 😃 |
cd6703a to
3a521fa
Compare
ianprime0509
changed the title
|
Thank you, and sorry for the delay! I just added some other changes and merged it in. |
2 participants
was messing about w/ the 0.16.x stuff so figured id share this. will try to keep it updated if any more changes in zig break things! just opening now in case this is helpful for anyone and/or we want to merge it when 0.16.x is released!
edit: tested using
0.16.0-dev.1246+4b593a6c2