chore: Zig master compatibility for main library#64
Closed
adoerr wants to merge 2 commits into
Closed
Conversation
Signed-off-by: adoerr <0xad@gmx.net>
There was a problem hiding this comment.
Pull request overview
This PR standardizes initialization of internal container fields in the XML Reader and Writer to use the explicit .empty initializer, improving clarity around “empty but valid” container state at construction.
Changes:
- Update
Writer.initto initializestrings,element_names, andns_prefixeswith.empty. - Update
Reader.initto initializespans,attributes,strings,element_names, andns_prefixeswith.empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Writer.zig |
Uses .empty for empty container initialization in Writer.init. |
src/Reader.zig |
Uses .empty for empty container initialization in Reader.init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
|
Sorry, just noticed this PR now, and after resolving conflicts, it looks like #65 took care of this. Thank you, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
std.ArrayListfield initialization for Reader and Writer .With this PR deprecated default values for
std.ArrayListhave been removed.We are affected by this, because the (also deprecated)
std.ArrayListUnmanagedis an aliasedstd.ArrayList. I haven't changedstd.ArrayListUnamagnedtostd.ArrayListin order to keep changes for this PR minimal.