Code review fixes#68
Draft
ianprime0509 wants to merge 7 commits into
Draft
Conversation
The previous logic didn't correctly implement the spec in checking cases related to explicit `xml` and `xmlns` namespace declarations.
Previously, we tried to split text nodes so they fit in the available buffer. This turned out to be rather complex, and potentially confusing for users. Now, we just expand to the full available node, even though it can use more memory in cases of very long runs of plain text. There were already other pathological documents which could result in higher memory use, so I'm not sure this is really a big deal compared to the complexity it replaces.
Avoids conflicts between `a:bc` and `ab:c`, etc.
ianprime0509
force-pushed
the
code-review-fixes
branch
from
July 21, 2026 00:34
fada17a to
6fe77e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP branch for addressing (potential) issues found by GLM 5.2 reviewing this codebase.
Not all reported findings will necessarily be addressed, but it did find some legitimate bugs.
Intended to be merged by dropping the "GLM 5.2 code review" commit once all findings have been addressed (or not) as desired, and then rebased.