fix: step numbers not visible in dark mode#178
fix: step numbers not visible in dark mode#178Chetan-KK wants to merge 1 commit intoibelick:mainfrom
Conversation
|
@Chetan-KK is attempting to deploy a commit to the julienthibeaut's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a dark mode visibility issue where step numbers were not visible because their background color was fixed to white. The fix changes hardcoded color values to use Tailwind CSS theme variables that automatically adapt to light and dark modes.
Changes:
- Updated step number styling to use dynamic theme variables (
border-borderandbg-background) instead of hardcoded light mode colors - Modified package-lock.json with numerous peer dependency flag changes
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/globals.css | Updated step number styling from hardcoded white background to theme-aware variables |
| package-lock.json | Extensive peer dependency flag modifications across multiple packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| &:before { | ||
| @apply absolute inline-flex h-9 w-9 items-center justify-center rounded-full border border-zinc-200 bg-white text-center -indent-px font-mono text-base font-medium dark:border-zinc-800 dark:bg-zinc-950; | ||
| @apply absolute inline-flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background text-center -indent-px font-mono text-base font-medium dark:border-zinc-800 dark:bg-zinc-950; |
There was a problem hiding this comment.
The dark mode classes dark:border-zinc-800 and dark:bg-zinc-950 are redundant after switching to border-border and bg-background. These theme variables already handle both light and dark modes automatically. The dark mode classes should be removed to avoid conflicts and ensure consistent theming behavior.
| @apply absolute inline-flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background text-center -indent-px font-mono text-base font-medium dark:border-zinc-800 dark:bg-zinc-950; | |
| @apply absolute inline-flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background text-center -indent-px font-mono text-base font-medium; |
before
steps bg color was fixed to white, because of that text was not visible on dark mode
fixed step color and it's border color to dynamic
after fix