Fix failing Next.js lint and build checks (Resolves #184)#185
Open
vass-k wants to merge 1 commit intoibelick:mainfrom
Open
Fix failing Next.js lint and build checks (Resolves #184)#185vass-k wants to merge 1 commit intoibelick:mainfrom
vass-k wants to merge 1 commit intoibelick:mainfrom
Conversation
- Removed incompatible tailwindcss plugin (Tailwind v4 conflict) and prettier from ESLint config. - Fixed missing display name error in TabsRoot component. - Fixed anonymous default export warning in Disclosure component. - Excluded cli directory from root Next.js tsconfig to prevent next build from crashing on missing CLI dependencies.
Contributor
|
@vass-k is attempting to deploy a commit to the julienthibeaut's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR completely resolves the
npm run lintandnpm run buildcrashes reported in #184. The repository's CI pipeline was quietly failing on fresh installs due to obsolete ESLint plugins, missing React display names, and TSConfig scope issues.Technical Details
1. ESLint Configuration Fixes
plugin:tailwindcss/recommended: The project uses Tailwind CSS v4, but the official ESLint plugin strictly requires v3.x and crashes with a peer dependency conflict on install.prettieroverride: The project does not haveeslint-config-prettierinstalled, causing the linter to throwFailed to load config "prettier"and halt. The defaultnext/core-web-vitalspreset does not conflict with prettier anyway, making this safely removable.2. React Definition Fixes
function TabsRoot) to theforwardRefto resolve thereact/display-nameerror violently thrown by Next.js's strict mode.Resolves #184 #184
No visual changes.