[security] Fix critical path traversal in conversations_db.rs#485
[security] Fix critical path traversal in conversations_db.rs#485iberi22 wants to merge 1 commit into
Conversation
…rsations_db.rs - Implemented strict character filtering in db_path (alphanumeric, -, _) - Added defense-in-depth path escape check using canonicalize - Refactored db_path to return Result and use dirs crate - Updated ConnectionManager to use sanitized ConversationsDb::db_path - Added unit tests for sanitization and traversal prevention
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Same situation as #494 - too far behind main. The path traversal fix will be re-applied fresh. |
1 participant
Sanitize project_id in ConversationsDb::db_path to allow only alphanumeric characters, hyphens, and underscores. Refactored the function to return a Result and use the dirs crate for robust home directory resolution. Consolidated path generation logic in ConnectionManager to use this sanitized path.
Fixes #428
PR created automatically by Jules for task 15548508301093936835 started by @iberi22