Skip to content

IBX-11766: Removed prod phpunit dependency#184

Draft
bnowak wants to merge 9 commits into
5.0from
IBX-11766-remove-prod-phpunit-dependency-part-2
Draft

IBX-11766: Removed prod phpunit dependency#184
bnowak wants to merge 9 commits into
5.0from
IBX-11766-remove-prod-phpunit-dependency-part-2

Conversation

@bnowak
Copy link
Copy Markdown

@bnowak bnowak commented May 14, 2026

Caution

  • Remove tmp commit before merging
🎫 Issue IBX-11766

Related PRs:

#183

Description:

The main goal is to unblock updating of phpunit/phpunit in ibexa/* dev dependencies to a version higher than 10. Currently, this package narrows it down to max version 10.

This PR moves phpunit to dev dependencies.

For QA:

Documentation:

@bnowak bnowak force-pushed the IBX-11766-remove-prod-phpunit-dependency-part-2 branch from 5cacdf4 to d3ba6d1 Compare May 14, 2026 12:04
@bnowak bnowak force-pushed the IBX-11766-remove-prod-phpunit-dependency-part-2 branch from d3ba6d1 to 7dd064b Compare May 15, 2026 08:07
@bnowak bnowak changed the title Ibx 11766 remove prod phpunit dependency part 2 IBX-11766: Removed prod phpunit dependency May 15, 2026
@bnowak bnowak force-pushed the IBX-11766-remove-prod-phpunit-dependency-part-2 branch from 7dd064b to 8404954 Compare May 15, 2026 08:50
@mnocon
Copy link
Copy Markdown
Contributor

mnocon commented May 15, 2026

Hi!

Maybe you've checked this already, but the reason phpunit was in the require section is that the Behat tests sometimes use PHPUnit assertions:
https://github.com/ibexa/page-builder/blob/5.0/src/lib/Behat/Component/Blocks/TextBlock.php#L77

so PHPUnit has to be installed on the project level when Behat tests are run.

Might be good to run regressions to verify before merging this - if they're green it will be ok 👍

@bnowak
Copy link
Copy Markdown
Author

bnowak commented May 15, 2026

Hi!

Maybe you've checked this already, but the reason phpunit was in the require section is that the Behat tests sometimes use PHPUnit assertions: https://github.com/ibexa/page-builder/blob/5.0/src/lib/Behat/Component/Blocks/TextBlock.php#L77

so PHPUnit has to be installed on the project level when Behat tests are run.

Might be good to run regressions to verify before merging this - if they're green it will be ok 👍

@mnocon
Yeah, I've checked that. The plan is to replace phpunit assertions with those from webmozart/assert library. It's quite popular (over 911 billion installs), stable and widely used in php applications. Also, it has not additional dependencies and is self-served. 😉

By running regressions, do you mean some more/additional tests which are not triggered by CI jobs? Could you shortly introduce me to that topic please?

@mnocon
Copy link
Copy Markdown
Contributor

mnocon commented May 15, 2026

By running regressions I mean running the whole test suite (not only the checks defined in the given repo), usually run by the QA by preparing a PR similar to this one: ibexa/commerce#1813

They'll help you with that once you're ready 😄

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants