-
Notifications
You must be signed in to change notification settings - Fork 3
IBX-11779: Updated Ibexa CS, PHPStan, and GHA #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f7baca8
d8c239b
1213861
90dac99
3c683a6
e799a80
69c9f0d
a46d404
4c60c39
69f97d2
3b83a24
11c89c2
3d90690
fbc8331
ef4d0e8
9113471
0a1a6e9
33f989e
e39601c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ on: | |
| jobs: | ||
| tests: | ||
| name: Tests | ||
| runs-on: "ubuntu-20.04" | ||
| runs-on: "ubuntu-latest" | ||
| timeout-minutes: 10 | ||
|
|
||
| strategy: | ||
|
|
@@ -20,26 +20,16 @@ jobs: | |
| - '8.3' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup PHP Action | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php }} | ||
| coverage: none | ||
| extensions: pdo_sqlite, gd | ||
| tools: cs2pr | ||
|
|
||
| - name: Add composer keys for private packagist | ||
| run: | | ||
| composer config http-basic.updates.ibexa.co $SATIS_NETWORK_KEY $SATIS_NETWORK_TOKEN | ||
| composer config github-oauth.github.com $TRAVIS_GITHUB_TOKEN | ||
| env: | ||
| SATIS_NETWORK_KEY: ${{ secrets.SATIS_NETWORK_KEY }} | ||
| SATIS_NETWORK_TOKEN: ${{ secrets.SATIS_NETWORK_TOKEN }} | ||
| TRAVIS_GITHUB_TOKEN: ${{ secrets.TRAVIS_GITHUB_TOKEN }} | ||
|
Comment on lines
-30
to
-40
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note Changes not needed for GHA run for the bundle generator itself, as it shouldn't install any Ibexa packages, except for Ibexa Code Style, which is served by Packagist. |
||
|
|
||
| - uses: "ramsey/composer-install@v3" | ||
| - uses: ramsey/composer-install@v4 | ||
|
barw4 marked this conversation as resolved.
|
||
| with: | ||
| dependency-versions: "highest" | ||
| composer-options: "--prefer-dist --no-progress --no-suggest" | ||
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note Deleted obsolete PR assignment workflow as it rather doesn't apply to this package. |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| sonar.cpd.exclusions=skeleton/** |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,2 @@ | ||
| parameters: | ||
| ignoreErrors: | ||
| - | ||
| message: "#^Cannot cast array\\<int, string\\>\\|bool\\|int\\|string to string\\.$#" | ||
| count: 1 | ||
| path: src/lib/Composer/ScriptHandler.php | ||
|
|
||
| - | ||
| message: "#^Parameter \\#1 \\$targetDir of method Ibexa\\\\BundleGenerator\\\\Generator\\\\BundleGeneratorConfiguration\\:\\:setTargetDir\\(\\) expects string\\|null, string\\|false given\\.$#" | ||
| count: 1 | ||
| path: src/lib/Composer/ScriptHandler.php | ||
|
|
||
| - | ||
| message: "#^Parameter \\#1 \\$path of function basename expects string, string\\|false given\\.$#" | ||
| count: 1 | ||
| path: src/lib/Generator/BundleGenerator.php | ||
|
|
||
| - | ||
| message: "#^Parameter \\#1 \\$str of function strtr expects string, string\\|false given\\.$#" | ||
| count: 1 | ||
| path: src/lib/Generator/BundleGenerator.php | ||
|
|
||
| - | ||
| message: "#^Parameter \\#1 \\$targetDir of method Ibexa\\\\BundleGenerator\\\\Generator\\\\BundleGenerator\\:\\:createSkeletonIterator\\(\\) expects string, string\\|null given\\.$#" | ||
| count: 1 | ||
| path: src/lib/Generator/BundleGenerator.php | ||
|
|
||
| - | ||
| message: "#^Parameter \\#2 \\$targetDir of method Symfony\\\\Component\\\\Filesystem\\\\Filesystem\\:\\:mirror\\(\\) expects string, string\\|null given\\.$#" | ||
| count: 1 | ||
| path: src/lib/Generator/BundleGenerator.php | ||
|
|
||
| ignoreErrors: [] |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note Obsolete, handled by org-wide PR template. |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Made GHA workflow completely not runnable as Ubuntu 20 has been discontinued on GHA.