IBX-6773: Fixed loading Bookmarks for non-accessible content items#476
Open
IBX-6773: Fixed loading Bookmarks for non-accessible content items#476
Conversation
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
bdac332 to
9164daa
Compare
Closed
6 tasks
|
adamwojs
changed the title
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
9164daa to
ec96060
Compare
konradoboza
reviewed
Feb 24, 2026
src/contracts/Repository/Values/Content/Query/Criterion/IsBookmarked.php
Outdated
Show resolved
Hide resolved
tests/lib/Persistence/Legacy/Filter/CriterionQueryBuilder/Location/BookmarkQueryBuilderTest.php
Outdated
Show resolved
Hide resolved
vidarl
commented
Feb 24, 2026
vidarl
commented
Feb 24, 2026
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
reviewed
Feb 24, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Did you make sure none of the deprecated classes are still in use?
Contributor
Author
|
@konradoboza : FYI : Had to add related PR : ibexa/admin-ui#1835 |
konradoboza
reviewed
Feb 25, 2026
Comment on lines
+1993
to
+1994
| $this->assertEquals($contactUsLocationId, $afterSwap->items[0]->id); | ||
| $this->assertEquals($beforeSwap->items[1]->id, $afterSwap->items[1]->id); |
Contributor
There was a problem hiding this comment.
Why this change? It's not clear at first glance.
Contributor
|
Please rebase the PR @vidarl. |
alongosz
changed the title
…n - PHPStand and BookmarkQueryBuilder
…n - PHPStand and Bookmark\IdSortClauseQueryBuilder
…n - Added more Strict typing
…tion/BookmarkQueryBuilderTest.php Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
alongosz
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
78b2c3b to
648ac3e
Compare
Member
|
PR rebased. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4.6Related PRs:
loadBookmarkscall with Repository filtering requirements admin-ui#1835Description:
If user bookmark some location which he later looses access too, then the bookmark list in admin-ui fails with an exception.
Simply fixing
BookmarkService::loadBookmarks()would be easy. The problem is to implementcountUserBookmarks()in persistence layer and having it taking into account user permissions so that BC would be kept.Talked with Adam on how to solve this without breaking BC and he suggested implementing it using filtering
The Bookmark filter will only work with location filtering (
LocationService::find()), not with content (ContentService::find())This is a port of ezsystems/ezplatform-kernel#408 which was not approved and merge in time before 3.3 went EOL.
For QA:
Read ticket for info on how to reproduce
Documentation:
Documentation for the new filter needs to be made, indeed