IBX-10976: Deleting user/user group breaks assigned role view#700
Open
IBX-10976: Deleting user/user group breaks assigned role view#700
Conversation
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
Steveb-p
approved these changes
Feb 5, 2026
konradoboza
reviewed
Feb 5, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
I would expect fixing it at the cache handler layer. Have you checked if the list of tags for the invalidation should be expanded there? What bothers me here is loading lots of data from the services layer just to generate tags. Besides, is it bulletproof when permissions don't allow fetching users or role assignments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fix consists of two additions working together:
buildLoadRoleAssignmentsQueryto only query the users/user groups that are published (not trashed)RoleAssignmentCacheInvalidationListenerto invalidate the cache as just moving the user to trash or restoring it doesn't invalidate it