-
Notifications
You must be signed in to change notification settings - Fork 82
[4.6] Doc for Elasticsearch 8 #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
konradoboza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very descriptive! One nitpick:
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments, some are preferential. If you agree with them, you may need to revisit the E8 doc for 5.x
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
| For more information, see: | ||
|
|
||
| - Elasticsearch 7: [SSL Encryption](https://www.elastic.co/guide/en/elasticsearch/client/php-api/7.x/connceting.html#ssl-encryption) | ||
| - Elasticsearch 8: [SSL Encryption](https://www.elastic.co/guide/en/elasticsearch/client/php-api/8.19/connecting.html#ssl-encryption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead link
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
* Added doc for ES8 * Added update guide mention * Fixed header * Formatting fixes * Apply suggestions from code review Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> * Apply suggestions from code review Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Manual changes --------- Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
* Removed warning about Safari (#2982) * 4.6.27: Update doc for dropped unused guzzle dependencies (#2995) * Added update section for 4.6.27 * Update docs/update_and_migration/from_4.6/update_from_4.6.md * Described virtual products and added an example creating product type with PHP API (#3024) * Described virtual products and added an example creating product type with PHP API * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> * Fixed invalid include * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Added link to user doc --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * [4.6] Doc for Elasticsearch 8 (#3022) * Added doc for ES8 * Added update guide mention * Fixed header * Formatting fixes * Apply suggestions from code review Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> * Apply suggestions from code review Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Manual changes --------- Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
* Removed warning about Safari (#2982) * 4.6.27: Update doc for dropped unused guzzle dependencies (#2995) * Added update section for 4.6.27 * Update docs/update_and_migration/from_4.6/update_from_4.6.md * Described virtual products and added an example creating product type with PHP API (#3024) * Described virtual products and added an example creating product type with PHP API * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> * Fixed invalid include * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Added link to user doc --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * [4.6] Doc for Elasticsearch 8 (#3022) * Added doc for ES8 * Added update guide mention * Fixed header * Formatting fixes * Apply suggestions from code review Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> * Apply suggestions from code review Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Manual changes --------- Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
Documentation for Elasticsearch 8 support in DXP 4.6