fix(graphhopper): Rename vehicle param to profile for routing requests with Graphhopper#1043
Merged
binh-dam-ibigroup merged 4 commits intoibi-group:devfrom Apr 2, 2026
Merged
Conversation
Thsi fixes Street Snapping when editing shapes in the GTFS editor. When I tried it with a local Graphhopper instance before, I got the error message "bad request: profile parameter required" from the routing request. At some point, Graphhopper switched from a `vehicle` parameter to `profile`, see graphhopper/graphhopper#1934.
Contributor
|
Closes #948 |
miles-grant-ibigroup
approved these changes
Mar 31, 2026
Contributor
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Thank you so much for this work!
binh-dam-ibigroup
approved these changes
Apr 1, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Nice fix, thank you
binh-dam-ibigroup
requested changes
Apr 1, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Merging as is will result in a bad merge, see my comment.
Contributor
|
The failures we're seeing now are normal! Since this PR is external. Once @binh-dam-ibigroup approves this is good to merge. Thanks so much for all your work! |
binh-dam-ibigroup
approved these changes
Apr 2, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Thanks for the changes! (Tests succeeded on #1053)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This fixes Street Snapping when editing shapes in the GTFS editor.
When I tried it with a local Graphhopper instance before, I got the error message "bad request: profile parameter required" from the routing request.
At some point, Graphhopper switched from a
vehicleparameter toprofile, see graphhopper/graphhopper#1934 and https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md#70-14-mar-2023There is already a PR #948 for updating this code, but it has not been edited since over two years. This edit aims to be minimally invasive to restore the routing functionality.