Merged
Conversation
miles-grant-ibigroup
requested changes
Mar 12, 2026
Contributor
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
I'm so excited for this. This type of work is so frustrating we should really celebrate getting somewhere
Contributor
E2E tests pass! |
| return ( | ||
| <Select | ||
| clearable | ||
| data-test-id='fare-product-selector' |
Contributor
There was a problem hiding this comment.
Am I right in thinking that the fares v1 tests have been removed?
Contributor
Author
There was a problem hiding this comment.
they have not been removed. This was an unneeded test ID for a v2 fare product selector.
Contributor
Author
There was a problem hiding this comment.
I added this on the OG fares v2 branch.
miles-grant-ibigroup
approved these changes
Mar 17, 2026
Contributor
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
It's looking really good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Add new e2e tests for fares v2. Uses vite to build the ui. also cleans up some todos and adds new types to satisfy CI requirements.