fix: include followRail in drawPatternFromStops to enable snap to rail and avoid thrown to else which always return straight line#1055
Open
faisalanshory wants to merge 1 commit intoibi-group:devfrom
Conversation
…l and avoid thrown to else which always return straight line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l and avoid thrown to else which always return straight line
Checklist
devbefore they can be merged tomaster)Description
This PR fixes an issue in the trip pattern editor where the "Snap to Rail" functionality was being ignored when generating a pattern shape from stops.
The Issue: Previously, the logic in drawPatternFromStops only prioritized followStreets. When a user selected "Snap to Rail" (which sets followRail to true), the code would fall through to the else block, which unconditionally generates straight line segments. This made it impossible to auto-generate rail-snapped geometries even when the routing engine (like GraphHopper) supported it.
The Fix: I have updated the condition in drawPatternFromStops to include followRail. Now, if either followStreets or followRail is enabled, the application correctly calls the routing service (getPolyline) with the appropriate parameters. This ensures that rail patterns are correctly snapped to tracks instead of defaulting to straight lines.