feat: add support for creating HPCC Initdata annotation#74
feat: add support for creating HPCC Initdata annotation#74Sashwat-K merged 6 commits intoibm-hyper-protect:mainfrom
Conversation
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
lib/hpccinitdata/hpccinitdata.go
Outdated
There was a problem hiding this comment.
change Parameter name to hpcc-init as suggested here
#70
docs/README.md
Outdated
There was a problem hiding this comment.
Typo: singed -> signed
docs/README.md
Outdated
There was a problem hiding this comment.
If --out is required then update this example accordingly
lib/hpccinitdata/hpccinitdata.go
Outdated
There was a problem hiding this comment.
keep this print statement after else statement as it is duplicate in both if, else
or
is this print statement is needed as for other commands will not print anything after output.
Any suggestion @Sashwat-K
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
lib/hpccinitdata/hpccinitdata.go
Outdated
There was a problem hiding this comment.
keep this print statement when you copied gzipped content in file
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
lib/hpccinitdata/hpccinitdata.go
Outdated
There was a problem hiding this comment.
do we need to specify HPCC here?
@Sashwat-K any suggestions on print message
|
Code changes is fine, but need to check on folder name |
lib/hpccinitdata/hpccinitdata.go
Outdated
There was a problem hiding this comment.
I would recommend to go forward with initdata instead of hpcc-init.
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
Sashwat-K
changed the title
README.md
Outdated
There was a problem hiding this comment.
No need to mention hpcc
mention init data generation or something similar...
There was a problem hiding this comment.
@Sashwat-K As we discussed that we can call out product names in DOCS for Now ?
There was a problem hiding this comment.
Hey @Rohit-Singh43-1 , remove the heading. Make it part of Contract Generation
cmd/initdata_test.go
Outdated
There was a problem hiding this comment.
remove this comment
Signed-off-by: Rohit Singh <Rohit.Singh43@ibm.com>
Sashwat-K
left a comment
Sashwat-K
left a comment
There was a problem hiding this comment.
Looks good to me! Congrats on your first PR merge @Rohit-Singh43-1 !
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Description
New flag is added with name
hpccinitdatawhich adds the initdata annotation creation support for Hyper Protect Confidential Containers.Related Issue
Fixes #70
Type of Change
Testing
Added unit test cases for functionality test
Checklist