Add preservePosition option to DragMarker#22
Open
invpt wants to merge 1 commit intoibrierley:masterfrom
Open
Conversation
Owner
|
Thanks for this, it sounds good initially and preservePosition sounds fine. I had played with using keys last weekend hoping to simplify things, but kept hitting problems when integrating with another plugin that swaps orders of dragMarkers, but maybe I can hack something with onPanUpdate there. Thanks again, it may be a few days before I get chance to test properly. |
Owner
|
Thanks for this, I think this looks good. I think there's a weird bug with web, where markers can vanish oddly (if they scroll the edge of the screen). However, I'm pretty sure this isn't related to your PR at all, but I may try and see if I can figure what's causing it before merging. |
|
Hi guys, any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would resolve #21. I realized that this option would be super easy to implement without losing any of the flexibility offered by allowing users to pass through a Key.
Let me know if you prefer a different name than
preservePosition. Also not sure if the&& !isDraggingis necessary.