fix mutating the input in snap_to_scalp_voxels#160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a super annoying bug - it took me a bit to identify its cause:
The problem
snap_to_scalp_voxelstakes a DataArray of optode positions (points) and figures out the nearest scalp-voxel coordinate for each. To return the snapped result, it did, but:Looks good, what's wrong?
Writing to .values rewrites my input data! So, even my unsnapped optodes were magically snapped after calling snap_to_scalp_voxels, and an optode location comparison of before and after snapping showed no change at all 🤯
🐍 🐍 🐍