Add licenses to containers#980
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the SAST/Snyk Tekton tasks from all ibutsu pipelines and adds license files into backend and frontend container build contexts, likely to embed or ship license information with the images. Flow diagram for updated Tekton pipeline tasks without sast-snyk-checkflowchart TD
prefetch_dependencies[prefetch-dependencies]
build_image_index[build-image-index]
clamav_scan[clamav-scan]
prefetch_dependencies --> build_image_index
build_image_index --> clamav_scan
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the sast-snyk-check task is removed from all Tekton pipelines, double-check that there are no remaining references to its params (e.g. sast-target-dirs, skip-checks) or assumptions about its outputs elsewhere in the pipeline definitions.
- The same structural change (removing sast-snyk-check) is repeated across multiple pipeline YAMLs; consider whether these can be generated from a shared template to reduce future duplication and drift.
- You’ve added LICENSE files under backend/licenses and frontend/licenses; ensure the updated Dockerfiles consistently copy these into the container images at a predictable path so downstream consumers can rely on their location.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the sast-snyk-check task is removed from all Tekton pipelines, double-check that there are no remaining references to its params (e.g. sast-target-dirs, skip-checks) or assumptions about its outputs elsewhere in the pipeline definitions.
- The same structural change (removing sast-snyk-check) is repeated across multiple pipeline YAMLs; consider whether these can be generated from a shared template to reduce future duplication and drift.
- You’ve added LICENSE files under backend/licenses and frontend/licenses; ensure the updated Dockerfiles consistently copy these into the container images at a predictable path so downstream consumers can rely on their location.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: Claude <noreply@anthropic.com>
b7794b1 to
29a7ddc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.36%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
===========================================
- Coverage 85.80% 74.36% -11.44%
===========================================
Files 63 154 +91
Lines 3620 7536 +3916
Branches 672 672
===========================================
+ Hits 3106 5604 +2498
- Misses 287 1705 +1418
Partials 227 227 see 91 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary by Sourcery
Remove SAST Snyk checks from Tekton pipelines and update container builds to include license files.
Build:
CI:
Chores: