Skip to content

Add licenses to containers#980

Merged
mshriver merged 1 commit into
ibutsu:mainfrom
mshriver:remove-sast-synk
Jul 22, 2026
Merged

Add licenses to containers#980
mshriver merged 1 commit into
ibutsu:mainfrom
mshriver:remove-sast-synk

Conversation

@mshriver

@mshriver mshriver commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Remove SAST Snyk checks from Tekton pipelines and update container builds to include license files.

Build:

  • Update backend and frontend Dockerfiles to incorporate newly added license files into built container images.

CI:

  • Remove sast-snyk-check tasks from all pull-request and push Tekton pipelines for backend, frontend, worker, scheduler, and flower components.

Chores:

  • Add LICENSE files for backend and frontend to support container licensing compliance.

@sourcery-ai

sourcery-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the SAST/Snyk Tekton tasks from all ibutsu pipelines and adds license files into backend and frontend container build contexts, likely to embed or ship license information with the images.

Flow diagram for updated Tekton pipeline tasks without sast-snyk-check

flowchart TD
  prefetch_dependencies[prefetch-dependencies]
  build_image_index[build-image-index]
  clamav_scan[clamav-scan]

  prefetch_dependencies --> build_image_index
  build_image_index --> clamav_scan
Loading

File-Level Changes

Change Details Files
Remove the sast-snyk-check task from all Tekton CI/CD pipelines for ibutsu services (backend, frontend, flower, scheduler, worker) for both push and pull-request workflows.
  • Delete the sast-snyk-check task entries from the task list in each pipeline spec.
  • Remove associated params wiring (image digest/url, TARGET_DIRS, SOURCE_ARTIFACT, CACHI2_ARTIFACT).
  • Remove taskRef configuration that referenced the external sast-snyk-check-oci-ta bundle.
  • Drop the conditional when block that ran the Snyk task based on skip-checks.
.tekton/ibutsu-backend-pull-request.yaml
.tekton/ibutsu-backend-push.yaml
.tekton/ibutsu-flower-pull-request.yaml
.tekton/ibutsu-flower-push.yaml
.tekton/ibutsu-frontend-pull-request.yaml
.tekton/ibutsu-frontend-push.yaml
.tekton/ibutsu-scheduler-pull-request.yaml
.tekton/ibutsu-scheduler-push.yaml
.tekton/ibutsu-worker-pull-request.yaml
.tekton/ibutsu-worker-push.yaml
Update Dockerfiles for all ibutsu service images and add LICENSE files under backend and frontend build contexts so containers can include license information.
  • Modify backend and service Dockerfiles (backend, flower, scheduler, worker) to account for the new licenses directory or license handling.
  • Modify the frontend Dockerfile to account for the new licenses directory or license handling.
  • Add backend/licenses/LICENSE with the project or distribution license text.
  • Add frontend/licenses/LICENSE with the project or distribution license text.
backend/docker/Dockerfile.backend
backend/docker/Dockerfile.flower
backend/docker/Dockerfile.scheduler
backend/docker/Dockerfile.worker
frontend/docker/Dockerfile.frontend
backend/licenses/LICENSE
frontend/licenses/LICENSE

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the sast-snyk-check task is removed from all Tekton pipelines, double-check that there are no remaining references to its params (e.g. sast-target-dirs, skip-checks) or assumptions about its outputs elsewhere in the pipeline definitions.
  • The same structural change (removing sast-snyk-check) is repeated across multiple pipeline YAMLs; consider whether these can be generated from a shared template to reduce future duplication and drift.
  • You’ve added LICENSE files under backend/licenses and frontend/licenses; ensure the updated Dockerfiles consistently copy these into the container images at a predictable path so downstream consumers can rely on their location.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the sast-snyk-check task is removed from all Tekton pipelines, double-check that there are no remaining references to its params (e.g. sast-target-dirs, skip-checks) or assumptions about its outputs elsewhere in the pipeline definitions.
- The same structural change (removing sast-snyk-check) is repeated across multiple pipeline YAMLs; consider whether these can be generated from a shared template to reduce future duplication and drift.
- You’ve added LICENSE files under backend/licenses and frontend/licenses; ensure the updated Dockerfiles consistently copy these into the container images at a predictable path so downstream consumers can rely on their location.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Co-authored-by: Claude <noreply@anthropic.com>
@mshriver mshriver changed the title Remove sast-synk tasks, add licenses to containers Add licenses to containers Jul 22, 2026
@mshriver
mshriver merged commit 2417ced into ibutsu:main Jul 22, 2026
18 checks passed
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.36%. Comparing base (39b5883) to head (29a7ddc).
⚠️ Report is 5 commits behind head on main.

❌ Your project status has failed because the head coverage (74.36%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #980       +/-   ##
===========================================
- Coverage   85.80%   74.36%   -11.44%     
===========================================
  Files          63      154       +91     
  Lines        3620     7536     +3916     
  Branches      672      672               
===========================================
+ Hits         3106     5604     +2498     
- Misses        287     1705     +1418     
  Partials      227      227               

see 91 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b5883...29a7ddc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant