Conversation
This commit resolves multiple bugs within the cluster filtering pipeline that prevented the `-C` flag from correctly filtering target clusters during the generation command.
Details:
- cmd/generate.go: Added `Filters.Clusters` to the validation check. Previously, cluster filtering wouldn't trigger unless `--clincludes` or `--clexcludes` were explicitly set, causing it to fall back to generating all clusters.
- pkg/util/util.go (CalculateClusterIncludesExcludes): Fixed a critical bug where the JSON parameter map value was appended to the generated cluster slice instead of the corresponding cluster name key.
- pkg/util/util.go (CalculateClusterIncludesExcludes): Implemented regex matching (`regexp.MatchString`) for cluster filtering, aligning the backend functionality with the CLI instruction documentation ("comma separated list of cluster names and/or regular expressions").
- pkg/util/util.go (FilterItems): Refactored the core include/exclude iteration loop to ensure that correctly matched clusters are actually recorded and appended into the final returned slice.
* rename * lint ver
B13rg
added a commit
that referenced
this pull request
Apr 18, 2026
* build * go fix ./... * version cfg * bugfix: where `--clusters`/`-C` flag was ignored during generation (#79) This commit resolves multiple bugs within the cluster filtering pipeline that prevented the `-C` flag from correctly filtering target clusters during the generation command. Details: - cmd/generate.go: Added `Filters.Clusters` to the validation check. Previously, cluster filtering wouldn't trigger unless `--clincludes` or `--clexcludes` were explicitly set, causing it to fall back to generating all clusters. - pkg/util/util.go (CalculateClusterIncludesExcludes): Fixed a critical bug where the JSON parameter map value was appended to the generated cluster slice instead of the corresponding cluster name key. - pkg/util/util.go (CalculateClusterIncludesExcludes): Implemented regex matching (`regexp.MatchString`) for cluster filtering, aligning the backend functionality with the CLI instruction documentation ("comma separated list of cluster names and/or regular expressions"). - pkg/util/util.go (FilterItems): Refactored the core include/exclude iteration loop to ensure that correctly matched clusters are actually recorded and appended into the final returned slice. * Fix workflows (#82) * rename * lint ver * Update deps * go fix * fix * naming/fmt * error check * exhaust struct * docs * fix warn * fix test * extract func * prealloc * fmt * cleanup path * cleanup * docs --------- Co-authored-by: Nick Parry <nick-parry@users.noreply.github.com>
B13rg
added a commit
that referenced
this pull request
Apr 18, 2026
* build * go fix ./... * version cfg * cleanup render and jsonnet commands * docs * bugfix: where `--clusters`/`-C` flag was ignored during generation (#79) This commit resolves multiple bugs within the cluster filtering pipeline that prevented the `-C` flag from correctly filtering target clusters during the generation command. Details: - cmd/generate.go: Added `Filters.Clusters` to the validation check. Previously, cluster filtering wouldn't trigger unless `--clincludes` or `--clexcludes` were explicitly set, causing it to fall back to generating all clusters. - pkg/util/util.go (CalculateClusterIncludesExcludes): Fixed a critical bug where the JSON parameter map value was appended to the generated cluster slice instead of the corresponding cluster name key. - pkg/util/util.go (CalculateClusterIncludesExcludes): Implemented regex matching (`regexp.MatchString`) for cluster filtering, aligning the backend functionality with the CLI instruction documentation ("comma separated list of cluster names and/or regular expressions"). - pkg/util/util.go (FilterItems): Refactored the core include/exclude iteration loop to ensure that correctly matched clusters are actually recorded and appended into the final returned slice. * Fix workflows (#82) * rename * lint ver * Go 1 26 (#81) * build * go fix ./... * version cfg * bugfix: where `--clusters`/`-C` flag was ignored during generation (#79) This commit resolves multiple bugs within the cluster filtering pipeline that prevented the `-C` flag from correctly filtering target clusters during the generation command. Details: - cmd/generate.go: Added `Filters.Clusters` to the validation check. Previously, cluster filtering wouldn't trigger unless `--clincludes` or `--clexcludes` were explicitly set, causing it to fall back to generating all clusters. - pkg/util/util.go (CalculateClusterIncludesExcludes): Fixed a critical bug where the JSON parameter map value was appended to the generated cluster slice instead of the corresponding cluster name key. - pkg/util/util.go (CalculateClusterIncludesExcludes): Implemented regex matching (`regexp.MatchString`) for cluster filtering, aligning the backend functionality with the CLI instruction documentation ("comma separated list of cluster names and/or regular expressions"). - pkg/util/util.go (FilterItems): Refactored the core include/exclude iteration loop to ensure that correctly matched clusters are actually recorded and appended into the final returned slice. * Fix workflows (#82) * rename * lint ver * Update deps * go fix * fix * naming/fmt * error check * exhaust struct * docs * fix warn * fix test * extract func * prealloc * fmt * cleanup path * cleanup * docs --------- Co-authored-by: Nick Parry <nick-parry@users.noreply.github.com> * task b --------- Co-authored-by: Nick Parry <nick-parry@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26.0