Open
Conversation
DataTriny
reviewed
Jun 4, 2023
text/0021-accessibility.md
Outdated
|
|
||
| ## Motivation | ||
|
|
||
| Accessibility support is an important feature for GUI toolkits. [Accesskit](https://github.com/AccessKit/accesskit) provides a cross-platform interface for interacting with accessibility software. It is still a work in progress, but already supports many widget types, and is used in egui. Accesibility support is currently missing in Iced, but could be implemented using Accesskit and the strategies in this proposal. |
There was a problem hiding this comment.
Suggested change
| Accessibility support is an important feature for GUI toolkits. [Accesskit](https://github.com/AccessKit/accesskit) provides a cross-platform interface for interacting with accessibility software. It is still a work in progress, but already supports many widget types, and is used in egui. Accesibility support is currently missing in Iced, but could be implemented using Accesskit and the strategies in this proposal. | |
| Accessibility support is an important feature for GUI toolkits. [Accesskit](https://github.com/AccessKit/accesskit) provides a cross-platform interface for interacting with accessibility software. It is still a work in progress, but already supports many widget types, and is used in egui. Accessibility support is currently missing in Iced, but could be implemented using Accesskit and the strategies in this proposal. |
| } | ||
| ``` | ||
|
|
||
| Buttons have a single child, which may also have children, so its implementation is requires an extra step of handling the children nodes. It is also more interactible than static text, so we can define actions that the accessibility tools may request to the widget. |
There was a problem hiding this comment.
Suggested change
| Buttons have a single child, which may also have children, so its implementation is requires an extra step of handling the children nodes. It is also more interactible than static text, so we can define actions that the accessibility tools may request to the widget. | |
| Buttons have a single child, which may also have children, so its implementation requires an extra step of handling the children nodes. It is also more interactible than static text, so we can define actions that the accessibility tools may request to the widget. |
text/0021-accessibility.md
Outdated
|
|
||
| ### A11yId | ||
|
|
||
| Accessibility Nodes need relatively consistent Ids for each element in the tree. A11yId is built using a slightly modified version of the existing `iced_native::widget::id::Id`. Because `iced_native` will depend on `iced_accessibility` the `Id` type is moved to `iced_core` and be re-exported by `iced_native`. |
There was a problem hiding this comment.
Suggested change
| Accessibility Nodes need relatively consistent Ids for each element in the tree. A11yId is built using a slightly modified version of the existing `iced_native::widget::id::Id`. Because `iced_native` will depend on `iced_accessibility` the `Id` type is moved to `iced_core` and be re-exported by `iced_native`. | |
| Accessibility Nodes need consistent IDs for each element in the tree. A11yId is built using a slightly modified version of the existing `iced_native::widget::id::Id`. Because `iced_native` will depend on `iced_accessibility` the `Id` type is moved to `iced_core` and re-exported by `iced_native`. |
text/0021-accessibility.md
Outdated
| }); | ||
| } | ||
| ``` | ||
| - reset widget Id counter before building the UserInterface |
There was a problem hiding this comment.
This seems very brittle to me as the IDs are tied to the order in which widgets are created. If for some reason a widget change its place in the "creation chain" during one frame, AccessKit will be confused.
Author
There was a problem hiding this comment.
Ok, ya this is a bit out of date, and I did run into exactly the issue you describe. After our short discussion earlier, I've decided to instead persist widget IDs when possible during the diff step. I will update the RFC to reflect the changes. Does that seem to be a better approach in your opinion?
There was a problem hiding this comment.
From what I recall, egui also computes a hash of some sort to generate IDs, which can be valid as well even though there's a tiny chance of collision.
If you can retain IDs between frames, it's indeed safer.
text/0021-accessibility.md
Outdated
| - Maybe there should be more helper methods for the different widget types? | ||
| - What related issues do you consider out of scope for this RFC that could be addressed in the future independently of the solution that comes out of this RFC? | ||
|
|
||
| Actual Widget implementations are somewhat out of scope of this RFC. Of course I hope that most widgets can be easily implemented with the skeleton proposed here, but it may become useful to define templates for different `Node`s or more helpers for building `A11yTree`s |
There was a problem hiding this comment.
I think you wanted this to replace the last item in the list above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered