Skip to content

Update 1.0.0#66

Open
KuzminVik wants to merge 6 commits intoicerockdev:developfrom
KuzminVik:update-1.0.0
Open

Update 1.0.0#66
KuzminVik wants to merge 6 commits intoicerockdev:developfrom
KuzminVik:update-1.0.0

Conversation

@KuzminVik
Copy link
Copy Markdown

No description provided.

@KuzminVik
Copy link
Copy Markdown
Author

it is required to implement the iOS code for Simple app

@ExNDY ExNDY requested review from Alex009 and ExNDY February 20, 2026 07:07
Comment thread paging/src/androidMain/AndroidManifest.xml Outdated
Comment thread gradle/libs.versions.toml Outdated
Comment thread paging/src/commonMain/kotlin/dev/icerock/moko/paging/PageCount.kt Outdated
Comment thread paging/src/commonMain/kotlin/dev/icerock/moko/paging/PageCount.kt Outdated
Comment thread paging/src/commonMain/kotlin/dev/icerock/moko/paging/PageCount.kt Outdated
Comment thread gradle.properties Outdated
Comment thread README.md
```kotlin
dependencies {
commonMainApi("dev.icerock.moko:paging:0.7.1")
commonMainApi("dev.icerock.moko:remotestate:0.1.0")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's should be another lib at all

Comment thread README.md Outdated
Comment thread README.md Outdated

package dev.icerock.moko.paging

actual open class BaseTestsClass
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it's created?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual class is needed for the expect class BaseTestsClass() to run tests in commonMain.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need implement coroutinesTest for commonMain and remove this old case

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commonTestImplementation(libs.coroutinesTest)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this will be ignored?

Comment thread README.md Outdated
Comment thread gradle/libs.versions.toml Outdated
Comment thread gradle/libs.versions.toml
mobileMultiplatformGradlePlugin = { module = "dev.icerock:mobile-multiplatform", version = "0.14.1" }
kotlinSerializationGradlePlugin = { module = "org.jetbrains.kotlin:kotlin-serialization", version.ref = "kotlinVersion" }
mokoUnitsGeneratorGradlePlugin = { module = "dev.icerock.moko:units-generator", version.ref = "mokoUnitsVersion" }
androidGradlePlugin = { module = "com.android.tools.build:gradle", version = "8.6.1" }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so high?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Compose dependencies (1.9.1) and lifecycle-runtime-compose (2.9.0) require AGP ≥ 8.6.0
Is this a big problem?

Copy link
Copy Markdown

@ExNDY ExNDY Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project doesn't need AGP 8.6, 8.1 more comfortable version, you need separate sample and library versions

Comment thread paging/src/androidMain/AndroidManifest.xml Outdated
Comment thread gradle/libs.versions.toml Outdated
Comment thread paging/build.gradle.kts
Comment thread paging/build.gradle.kts
}

dependencies {
commonMainApi(projects.remotestate)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread sample/android-app/src/main/java/com/icerockdev/PagingScreen.kt Outdated
Comment thread README.md Outdated
Comment thread README.md
- Gradle version 6.8+
- Android API 16+
- iOS version 11.0+
- Gradle 8.10+
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so highest version???

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports AGP Version 8.6.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library must support a wide range of versions (e.g., ensuring compatibility with AGP versions older than 8.6.1)

import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.test.runTest

actual fun <T> runTest(block: suspend CoroutineScope.() -> T): T {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants