Skip to content
This repository was archived by the owner on Jun 9, 2026. It is now read-only.

Remove the now-unused cache digest code#328

Merged
icing merged 1 commit into
icing:masterfrom
notroj:remove-unused-cache-digest
Jun 5, 2026
Merged

Remove the now-unused cache digest code#328
icing merged 1 commit into
icing:masterfrom
notroj:remove-unused-cache-digest

Conversation

@notroj

@notroj notroj commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

  gset_encode_bit, cmp_puint64): Remove unused cache digest functions
  and supporting golomb set encoder.

* mod_http2/h2_push.h (h2_push_diary_digest_get): Remove declaration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@icing

icing commented Jun 5, 2026

Copy link
Copy Markdown
Owner

@notroj with the recent submits to the module into subversion trunk, this repository is no longer "clean". I have no plans to continue to synch this for people who drop things into trunk without taking care of maintenance.

I'll merge this here. Just be aware that there are no plans by me for synching this with trunk.

@icing icing merged commit 81be920 into icing:master Jun 5, 2026
2 checks passed
@notroj

notroj commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@icing thanks a lot! I don't think anybody expects you particularly to put that effort in, it's kind of inevitable if we have a fork of mod_h2 with code in two places that one of them is going to get stale. I'll submit some MRs later today to bring in some of the recent changes.

@notroj notroj deleted the remove-unused-cache-digest branch June 5, 2026 12:35
@covener

covener commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

I mean this in a positive way only -- but I think NOT having it in SVN trunk would be a good guardrail to make it clear that this repo is effectively trunk.

(as one of the recent culprits, sorry for the trouble)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants