Consider surface constants and coordinates to be a Sequence, not an Iterable#926
Merged
MicahGale merged 6 commits intominor-rel-devfrom Mar 10, 2026
Merged
Consider surface constants and coordinates to be a Sequence, not an Iterable#926MicahGale merged 6 commits intominor-rel-devfrom
MicahGale merged 6 commits intominor-rel-devfrom
Conversation
MicahGale
requested changes
Mar 10, 2026
Collaborator
MicahGale
left a comment
There was a problem hiding this comment.
Looks pretty good. Changelog isn't necessary. Probably should go through the entire code base too.
Collaborator
Author
|
Not sure why $ python -m black tests/
All done! ✨ 🍰 ✨
33 files left unchanged.
$ python -m black --version
python -m black, 25.1.0 (compiled: yes)
Python (CPython) 3.13.2
Every other use of |
Collaborator
Author
|
Perhaps it is time to revise the |
Collaborator
Yeah let's make an issue to make the CI job just commit the changes if needed. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
Previously, the type checker verified that surface coordinates and coefficients were instances of
Iterable. This was overly permissive, as it would allow objects like sets and generators to be used. Now, they only allowed to be instances ofSequence, which has a definite order and length.Fixes #914
General Checklist
blackversion 25 or 26.LLM Disclosure
Are you?
Were any large language models (LLM or "AI") used in to generate any of this code?
Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--926.org.readthedocs.build/en/926/