Update llzk-lib and fix idiv and mod#396
Closed
tim-hoffman wants to merge 117 commits intoiden3:masterfrom
Closed
Conversation
* [fix upstream] Comment out failing tests * [fix upstream] use different paths to avoid flaky test failure * [fix upstream] fix/hide warnings * [fix upstream] add debug output for ProgramArchive
* add nix flake * add LLZK dependencies * add llzk output flag * add testing framework * Add '--dump_parse' flag for dev and use it for e2e test * add CI workflow
* remove redundant dependency `llzk` already brings in `llzk-sys` and other necessary crates * update dependency version
…#153) * refactor to support lints and clippy restrict clippy to just llzk backend by running `cargo clippy -p llzk_backend -- --no-deps` * fix clippy issues
* also remove undefined "matrix" reference
* fix ineffective "CHECK" lines * add/update tests showing duplication of circom functions per call-site
…nctions within structs (#157)
* fix API-related `todo` * add expected output for tests that now pass
* Implement constant dim expressions for prefix, infix ops * Implement static computation of dimensions * Run format * Add tests
* fix documentation * add missing Debug traits * translate While statement in functions * handle return statement within loop body * update a comment to be consistent
* Checkpoint * Implement Expression::ParallelOp in templates and functions * Update parallel op handling
* First iteration of write chain * Cleanup the current code * Remove XFAIL from test * Add test with subcomponents in arrays * Update tests * Revert change in ignore file * Add script for updating test cases * Cleanup warnings * Fix broken merge * Update test that passes in CI * Stray line * Update comment * Autoformat crate * Apply suggestions from code review Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Update incorrect comment * Rename test files and remove comments * Add use after if-then block for testing what SSA value is used --------- Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
* propagate `--verbose` flag to `LlzkCodegen` * Print error with stacktrace if verbose flag is set * use verbose flag to print current function/template
- Adds support for template parameters as array - Refactors convert_dim_expr functionality to be context-specific - Removed circom/tests/loops/vanguard-uc-comp.circom since it was redundant with other tests --------- Co-authored-by: Tim Hoffman <timothy.hoffman@veridise.com>
* Add shared uniform array impl, add basic tests * Update passing tests * Run clippy * Address code review comments, add test case * make test output easier to understand * Apply suggestions from code review Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Formatting * Add clone --------- Co-authored-by: Tim Hoffman <timothy.hoffman@veridise.com> Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
* Handle read/write consistently * Use `MemoryKnowledge` for decl if available * revert: debug printing on verify failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.