Repaired prevent erroneous afterRender triggers#19
Open
hollis21 wants to merge 1 commit intoifandelse:masterfrom
Open
Repaired prevent erroneous afterRender triggers#19hollis21 wants to merge 1 commit intoifandelse:masterfrom
hollis21 wants to merge 1 commit intoifandelse:masterfrom
Conversation
Repaired the workaround that prevented afterRender from being triggered on the "Loading..." text being shown. afterRender replacement was being done to options only internal to ExternalTemplateSource so the binding's options weren't being changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repaired the workaround that prevented afterRender from being triggered on the "Loading..." text being shown.
afterRender replacement was being done to options only internal to ExternalTemplateSource so the binding's options weren't being changed.