Fix: Handle Taskwarrior UTC due dates and improve time comparison#1
Open
Randalix wants to merge 1 commit intoifben:masterfrom
Open
Fix: Handle Taskwarrior UTC due dates and improve time comparison#1Randalix wants to merge 1 commit intoifben:masterfrom
Randalix wants to merge 1 commit intoifben:masterfrom
Conversation
The due dates from taskwarrior are in UTC, but task2ntfy was comparing them against local time without converting. For you in CET (UTC+1), this shrank the time difference, and num_hours() truncation to whole hours meant tasks due within the next hour were silently dropped (rounded to 0, failing the > 0 check). What I fixed in main.rs: 1. Properly convert the UTC due date to local time before comparison 2. Use num_minutes() instead of num_hours() to avoid truncation issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The due dates from taskwarrior are in UTC, but task2ntfy was comparing them against local time without converting. For you in CET (UTC+1), this shrank the time difference, and num_hours() truncation to whole hours meant tasks due within the next hour were silently dropped (rounded to 0, failing the > 0 check).
What I fixed in main.rs: