Skip to content

cibuildwheel enable pypy pypy-eol graalpy#159

Merged
ifduyue merged 1 commit into
masterfrom
duyue/cibuildwheel-enable-in-pyproject.toml
Jun 15, 2026
Merged

cibuildwheel enable pypy pypy-eol graalpy#159
ifduyue merged 1 commit into
masterfrom
duyue/cibuildwheel-enable-in-pyproject.toml

Conversation

@ifduyue

@ifduyue ifduyue commented Jun 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 148 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing duyue/cibuildwheel-enable-in-pyproject.toml (09035e8) with master (d8a3b99)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the development version of xxhash and attempts to configure cibuildwheel to support PyPy and GraalPy. However, the use of the enable option in pyproject.toml is invalid and will cause a configuration error. It is recommended to use the build option with the correct selectors instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pyproject.toml
build-backend = "setuptools.build_meta"

[tool.cibuildwheel]
enable = ["pypy", "pypy-eol", "graalpy"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The enable option is not a valid configuration key for [tool.cibuildwheel]. Using an invalid option will cause cibuildwheel to fail with a ConfigError (e.g., Unknown option: tool.cibuildwheel.enable).

To build PyPy and GraalPy wheels, you should use the build option with the appropriate selectors (pp* for PyPy and gp* for GraalPy). Note that pypy-eol is not a recognized selector or option in cibuildwheel.

Additionally, you may want to update the classifiers in setup.py to include PyPy and GraalPy implementations once this is resolved.

Suggested change
enable = ["pypy", "pypy-eol", "graalpy"]
build = ["cp*", "pp*", "gp*"]

@ifduyue ifduyue merged commit 4f9b8c4 into master Jun 15, 2026
47 checks passed
@ifduyue ifduyue deleted the duyue/cibuildwheel-enable-in-pyproject.toml branch June 15, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant