Skip to content

Build pyodide wasm32 wheels#160

Merged
ifduyue merged 1 commit into
masterfrom
pyodide
Jun 15, 2026
Merged

Build pyodide wasm32 wheels#160
ifduyue merged 1 commit into
masterfrom
pyodide

Conversation

@ifduyue

@ifduyue ifduyue commented Jun 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyproject.toml configuration to enable Pyodide builds in cibuildwheel. Feedback was provided to correct the identifiers used in the enable list, as "pyodide-prerelease" and "pyodide-eol" are unsupported, and "pyodide" should be used instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pyproject.toml

[tool.cibuildwheel]
enable = ["pypy", "pypy-eol", "graalpy"]
enable = ["pypy", "pypy-eol", "graalpy", "pyodide-prerelease", "pyodide-eol"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In cibuildwheel, the correct identifier to enable Pyodide builds is "pyodide". The identifiers "pyodide-prerelease" and "pyodide-eol" are not supported by cibuildwheel and may cause configuration errors or prevent Pyodide wheels from being built. Please update the enable list to use "pyodide".

Suggested change
enable = ["pypy", "pypy-eol", "graalpy", "pyodide-prerelease", "pyodide-eol"]
enable = ["pypy", "pypy-eol", "graalpy", "pyodide"]

@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 148 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing pyodide (b29899d) with master (81f5627)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ifduyue ifduyue merged commit 8114fd1 into master Jun 15, 2026
48 checks passed
@ifduyue ifduyue deleted the pyodide branch June 17, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant