Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml configuration to enable Pyodide builds in cibuildwheel. Feedback was provided to correct the identifiers used in the enable list, as "pyodide-prerelease" and "pyodide-eol" are unsupported, and "pyodide" should be used instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| [tool.cibuildwheel] | ||
| enable = ["pypy", "pypy-eol", "graalpy"] | ||
| enable = ["pypy", "pypy-eol", "graalpy", "pyodide-prerelease", "pyodide-eol"] |
There was a problem hiding this comment.
In cibuildwheel, the correct identifier to enable Pyodide builds is "pyodide". The identifiers "pyodide-prerelease" and "pyodide-eol" are not supported by cibuildwheel and may cause configuration errors or prevent Pyodide wheels from being built. Please update the enable list to use "pyodide".
| enable = ["pypy", "pypy-eol", "graalpy", "pyodide-prerelease", "pyodide-eol"] | |
| enable = ["pypy", "pypy-eol", "graalpy", "pyodide"] |
Merging this PR will not alter performance
Comparing Footnotes
|
No description provided.