Send exactly the same message to kafka that's used in the hash function....#3
Open
hamtie wants to merge 1 commit intoifwe:masterfrom
Open
Send exactly the same message to kafka that's used in the hash function....#3hamtie wants to merge 1 commit intoifwe:masterfrom
hamtie wants to merge 1 commit intoifwe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... (Fixes #2)
The crc32 hashing function was encoding messages before hashing. The node-kafka client, however, was creating the message with the raw string instead of the encoded string used in the hash. The kafka server was rejecting the message because the checksum was failing. This was causing any non-ascii strings to fail.