chore: refresh dependencies (keep parallel on 1.x) + hermetic test env#82
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates dependency version constraints in the Gemfile and gemspec (concurrent-ruby, cgi, json, parallel), adds new .gitignore patterns for rs-guard runtime artifacts, and modifies test_helper.rb to delete ENV variables matching ChangesDependency and Configuration Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependencies: - Keep parallel on ~> 1.26 (resolves 1.28.0). parallel 2.x requires Ruby >= 3.3, which would silently break this gem's declared required_ruby_version '>= 3.1'; the code only uses the stable Parallel.map(..., in_threads:) API, so 1.x is fine. - Patch-bump cgi (~> 0.5.2) and json (~> 2.20); dev dep concurrent-ruby (>= 1.3.7). - gitignore local review-tool artifacts (.rs-guard/, review-result.txt, rs-guard-metrics.json). Tests: - test_helper strips inherited *_API_KEY env vars so validate/provider-resolution tests are hermetic and don't pass/fail based on the developer's exported keys.
igmarin
force-pushed
the
fix/test-hermetic-env-keys
branch
from
July 1, 2026 00:10
4f47673 to
5868400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related bits of release hygiene:
Dependencies
parallelon~> 1.26(resolves 1.28.0).parallel2.x requires Ruby ≥ 3.3, which would silently break this gem's declaredrequired_ruby_version = '>= 3.1'. The code only uses the stableParallel.map(…, in_threads:)API, so there's no reason to require 2.x. This keeps Ruby 3.1/3.2 installable.cgi(~> 0.5.2) andjson(~> 2.20); dev-depconcurrent-ruby(>= 1.3.7)..gitignorelocal review-tool artifacts.Tests
test_helperstrips inherited*_API_KEYenv vars so thevalidate/provider-resolution tests are hermetic. Previously, a realOPENAI_API_KEYexported in the shell made 'missing credentials' assertions pass, sorake testwent red locally while CI (no keys) stayed green.Verification
rake test→ 888 runs, 0 failures/errors (parallel 1.28.0).rubocopclean.parallel1.28.0 requires Ruby ≥ 2.7, consistent with>= 3.1.