Merged
Conversation
Collaborator
|
Tests are failing due to the np.in1d function which was removed. I think there was already a PR merged fixing this. We should merge master back into this branch to fix that. I'm not sure I understand your comment about camb, I see it added to the requirements. Otherwise, I think it makes sense to use a templateif it is easier to ensure consistency between picca and vega |
merging fix in main to pass tests
Contributor
|
Now passing test, @iprafols if you agree with the changes we can push to main |
iprafols
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch uses a fiducial comology template to compute distances in Picca. The same template can be passed to Vega, making it easy to be consistent in the fiducial cosmologies we use for the catalogue + the fits. It also allows us to store templates for specific runs in Picca.
Note: this currently requires camb to be installed (I haven't added anything in requirements). I'm not necessarily asking for this branch to be merged, but I think it could be a nice idea.