Skip to content

merging fix in main to pass tests#1129

Merged
corentinravoux merged 3 commits intotemplate-cosmofrom
main
Mar 30, 2026
Merged

merging fix in main to pass tests#1129
corentinravoux merged 3 commits intotemplate-cosmofrom
main

Conversation

@corentinravoux
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI and others added 3 commits March 23, 2026 21:37
Co-authored-by: andreicuceu <28951059+andreicuceu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/igmhub/picca/sessions/a84f61d6-2f15-418c-8701-3552c51ed26b
…acement

Replace deprecated `np.in1d` with `np.isin`
Copilot AI review requested due to automatic review settings March 30, 2026 12:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates array membership checks across the codebase to maintain compatibility with the project’s NumPy requirement (numpy>=2.0.0) and ensure tests pass under NumPy 2.x.

Changes:

  • Replaced deprecated/removed np.in1d usages with np.isin across analysis, I/O, and CLI utilities.
  • Kept behavior consistent for boolean masks used in filtering and HEALPix alignment logic.

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tutorials/picca_export_stacked_correlation.py Uses np.isin when aligning HEALPix IDs across stacked inputs.
py/picca/xcf.py Uses np.isin in Wick-term computation when intersecting neighbour sets.
py/picca/raw_io.py Uses np.isin to quickly skip files / filter objects by THING_ID (MOCKID).
py/picca/pk1d/compute_pk1d.py Uses np.isin to build the “valid index” mask when filling masked pixels.
py/picca/delta_extraction/quasar_catalogues/drq_catalogue.py Uses np.isin to match spAll spectra to DRQ catalogue THING_IDs.
py/picca/cf.py Uses np.isin to select cross-correlation neighbours by matching thing IDs.
py/picca/bin/picca_reduce_spall.py Uses np.isin to filter spAll rows by QSO catalogue THING_ID.
py/picca/bin/picca_export_cross_covariance.py Uses np.isin when adding unshared HEALPix as empty data.
py/picca/bin/picca_export_co.py Uses np.isin when reconciling HEALPix sets across correlation types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@corentinravoux corentinravoux merged commit ce0e8c5 into template-cosmo Mar 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants