merging fix in main to pass tests#1129
Merged
corentinravoux merged 3 commits intotemplate-cosmofrom Mar 30, 2026
Merged
Conversation
Co-authored-by: andreicuceu <28951059+andreicuceu@users.noreply.github.com> Agent-Logs-Url: https://github.com/igmhub/picca/sessions/a84f61d6-2f15-418c-8701-3552c51ed26b
…acement Replace deprecated `np.in1d` with `np.isin`
Contributor
There was a problem hiding this comment.
Pull request overview
Updates array membership checks across the codebase to maintain compatibility with the project’s NumPy requirement (numpy>=2.0.0) and ensure tests pass under NumPy 2.x.
Changes:
- Replaced deprecated/removed
np.in1dusages withnp.isinacross analysis, I/O, and CLI utilities. - Kept behavior consistent for boolean masks used in filtering and HEALPix alignment logic.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tutorials/picca_export_stacked_correlation.py | Uses np.isin when aligning HEALPix IDs across stacked inputs. |
| py/picca/xcf.py | Uses np.isin in Wick-term computation when intersecting neighbour sets. |
| py/picca/raw_io.py | Uses np.isin to quickly skip files / filter objects by THING_ID (MOCKID). |
| py/picca/pk1d/compute_pk1d.py | Uses np.isin to build the “valid index” mask when filling masked pixels. |
| py/picca/delta_extraction/quasar_catalogues/drq_catalogue.py | Uses np.isin to match spAll spectra to DRQ catalogue THING_IDs. |
| py/picca/cf.py | Uses np.isin to select cross-correlation neighbours by matching thing IDs. |
| py/picca/bin/picca_reduce_spall.py | Uses np.isin to filter spAll rows by QSO catalogue THING_ID. |
| py/picca/bin/picca_export_cross_covariance.py | Uses np.isin when adding unshared HEALPix as empty data. |
| py/picca/bin/picca_export_co.py | Uses np.isin when reconciling HEALPix sets across correlation types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.